search

emmanueltouzery / prelude-ts

Functional programming, immutable collections and FP constructs for typescript and javascript
ISC License
377 stars 21 forks source link

Throw an Error instead of a string when there's a contract violation #65

Closed malcolmredheron closed 1 year ago

malcolmredheron commented 1 year ago

Change the default to throw an Error when there's a contact violation

As described in https://github.com/emmanueltouzery/prelude-ts/issues/59, this means that we get stack traces in testing environments when preludeTsContractViolationCb is called.

malcolmredheron commented 1 year ago

BTW, I ran npm run test manually and everything passed.

emmanueltouzery commented 1 year ago

thank you! previously i picked "rebase and merge" i think. this time "squash and merge"... just FYI.

malcolmredheron commented 1 year ago

Ah. Both of those will change the commit hash, I believe. Going forward, would you be ok doing a regular merge (ie, no squash or rebase)?

On Mon, Sep 26, 2022 at 12:57 PM, emmanueltouzery < @.*** > wrote:

thank you! previously i picked "rebase and merge" i think. this time "squash and merge"... just FYI.

— Reply to this email directly, view it on GitHub ( https://github.com/emmanueltouzery/prelude-ts/pull/65#issuecomment-1258547238 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAAOIXN4HGA6445M5BDD2U3WAH52PANCNFSM6AAAAAAQWC6YF4 ). You are receiving this because you authored the thread. Message ID: <emmanueltouzery/prelude-ts/pull/65/c1258547238 @ github. com>

emmanueltouzery commented 1 year ago

with an extra merge commit? sure, if it offers me i'll do it.

malcolmredheron commented 1 year ago

Thanks! I think that will make this quite a bit smoother on my end.

On Mon, Sep 26, 2022 at 1:08 PM, emmanueltouzery < @.*** > wrote:

with an extra merge commit? sure, if it offers me i'll do it.

— Reply to this email directly, view it on GitHub ( https://github.com/emmanueltouzery/prelude-ts/pull/65#issuecomment-1258558989 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAAOIXO2C6NN7NQLI32JAOTWAH7DLANCNFSM6AAAAAAQWC6YF4 ). You are receiving this because you authored the thread. Message ID: <emmanueltouzery/prelude-ts/pull/65/c1258558989 @ github. com>