search

emmarichardson / local_autogroup

A local plugin for Moodle 2.7 onwards which handles the dynamic creation, population and cleanup of groups on courses.
6 stars 19 forks source link

MOODLE_INTERNAL usage #19

Closed OlenaTatarintseva closed 1 year ago

OlenaTatarintseva commented 5 years ago

Hello,

It looks like most of *.php files don't use defined('MOODLE_INTERNAL') || die();

e.g locallib.php

I am not sure is there any reason to skip this check?

Thanks a lot for your job with this plugin.

Best regards, Olena Tatarintseva

emmarichardson commented 5 years ago

Please feel free to put in a pull request if there are changes you are looking for. Currently, I don't have anyone actively working on this.

Kemmotar83 commented 1 year ago

Hi Emma,

it seems you need help with this plugin and I'm glad to do my part (we use it in our university and it is very helpful).

If you agree I can make a code refactoring in order to have a code checker compliance (no feature or other business logic additions). This could be a helpful first step for further code evolutions (like the one I opened yesterday).

Regards, Giorgio

ak4t0sh commented 1 year ago

Hi @Kemmotar83 and @emmarichardson (it's been a while :) ) I agree a code refactor would facilitate maintenance and new features and a help on this would be more than welcomed :) I currently have no time to work on it but if you create dedicated issue (other than #38) and pull request I'll try to review your changes. Concerning your fix no need to wait for the refactor if you could provide a proper patch. (see my comment in #38)

Kemmotar83 commented 1 year ago

Hi @ak4t0sh ,

I'm really glad to help. I'll create a new issue and submit the request. I have to admit that I was confident and I've already done the refactoring.

Giorgio

Kemmotar83 commented 1 year ago

I think this issue can be closed.