Fix #16 default group by

emmarichardson / local_autogroup

A local plugin for Moodle 2.7 onwards which handles the dynamic creation, population and cleanup of groups on courses.

6 stars 19 forks source link

Fix #16 default group by #25

Closed luukverhoeven closed 4 years ago

luukverhoeven commented 4 years ago

array_merge doesn't respect array keys
fix autogroup_set sortmodule if field is an custom profile field

gemguardian commented 4 years ago

ping @emmarichardson :)

emmarichardson commented 4 years ago

@luukverhoeven I mentioned to Gemma that I have another pull request ahead of this that I never got merged because I did not get it tested. I am testing pull request #13 today - if it tests ok, I will go ahead and merge it. I will then need you to review to make sure that nothing in the first merge affects your PR...once you have confirmed that, I will test yours and get it merged. Sorry it has been so slow - I tend to rely on @ak4t0sh way more than I should and I have been ridiculously busy with COVID to even look at these, as I am sure he has too!

emmarichardson commented 4 years ago

I have merged the other PR (#13). Please check and make sure that your PR still is ready for testing. Thanks.

luukverhoeven commented 4 years ago

@emmarichardson Thanks for your time. I validated the merged version and the patch still works correct 😃

ak4t0sh commented 4 years ago

sorry for the delay. I'll try to review this PR today

emmarichardson commented 4 years ago

Thanks for reviewing. I will get it merged today and update the plugin database.

On Thu, Sep 3, 2020, 9:38 AM Arnaud Trouvé notifications@github.com wrote:

@ak4t0sh approved this pull request.

Thanks for the fix @luukverhoeven https://github.com/luukverhoeven ! @emmarichardson https://github.com/emmarichardson it seems perfect for integration and ready for release (even release number have been increased to right version as we can not ensure backward compatibility !)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/emmarichardson/local_autogroup/pull/25#pullrequestreview-481965494, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAP3TGMOSCMWJVQWXPOEFITSD6Z7VANCNFSM4PIYXU3Q .

emmarichardson commented 4 years ago

Merged and updated to Moodle plugins database. Thank you so much for the fix and the patience!

gemguardian commented 4 years ago

Thank you all!

luukverhoeven commented 4 years ago

👍

@ak4t0sh Thanks for the review! @emmarichardson Thanks for the merged and update.