search

emmarichardson / local_autogroup

A local plugin for Moodle 2.7 onwards which handles the dynamic creation, population and cleanup of groups on courses.
6 stars 19 forks source link

Fix issue #38 #41

Closed Kemmotar83 closed 1 year ago

Kemmotar83 commented 1 year ago

Fix issue #38

Kemmotar83 commented 1 year ago

Hi @emmarichardson and @ak4t0sh ,

let me know if this fix works or there's anything to edit.

Giorgio

emmarichardson commented 1 year ago

Ok, back from Mexico - work has slowed down ever so slightly - my testing showed no issues. @ak4t0sh Have you had a chance to review?

ak4t0sh commented 1 year ago

sorry for the late answer. Not tested but seems good to me.

emmarichardson commented 1 year ago

Thanks will merge tomorrow

Emma Richardson Distance Learning Coordinator 719-771-4022 Need to visit? Click below to schedule an appointment. https://calendar.app.google/vy9C7FEp2GCNQrbE7

On Mon, Mar 6, 2023, 5:44 PM Arnaud Trouvé @.***> wrote:

sorry for the late answer. Not tested but seems good to me.

— Reply to this email directly, view it on GitHub https://github.com/emmarichardson/local_autogroup/pull/41#issuecomment-1457046963, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAP3TGKH557YHWT2XL7E36DW2ZLEVANCNFSM6AAAAAAT7FQU2A . You are receiving this because you were mentioned.Message ID: @.***>

emmarichardson commented 1 year ago

I have merged this pull request. I will be testing the next pull request tomorrow and will most probably merge that one before updating plugins database.