Java configurator improvement

emmebrusa / TSDZ2-Smart-EBike-1

TSDZ2 Open Source Firmware adapted to VLCD5-VLCD6-XH18 displays

GNU General Public License v3.0

133 stars 35 forks source link

Java configurator improvement #45

Closed dzid26 closed 1 year ago

dzid26 commented 1 year ago

Added user confirmation at the end of flashing to verify everything went fine (Windows)
Java configurator list behaves better now:
- latest file is loaded and the element from the top experimental is highlighted.
- after compiling, a new file is added on top and highlighted, so now it is more clear which one is loaded and sorting is not messed up

emmebrusa commented 1 year ago

Added user confirmation at the end of flashing to verify everything went fine (Windows)

This change was also in the previous pull request. I had deleted it on purpose, I'll explain why. I've always thought that if the window closes it's because everything went well, while if the window stays open something went wrong. Do you think flashing can end badly and the window close even with an error message present?

dzid26 commented 1 year ago

Ah, I see. Well, when I used it after the merge, I noticed it closed, but at that point I wasn't sure if everything went fine, or the cable was bad, or installation bad. I just didn't remember the behavior so I quickly added the wait screen so I don't have to guess. Surely new users are confused enough, and the less guessing the better.

I don't remember if window stays opened for all kind of fails.

We could add a explicit text "Flash successful, press any key to close".