emmebrusa / TSDZ2-Smart-EBike-1

TSDZ2 Open Source Firmware adapted to VLCD5-VLCD6-XH18 displays
GNU General Public License v3.0
144 stars 34 forks source link

Configurator UI and error handling improvements #92

Open ec-bikes opened 6 months ago

ec-bikes commented 6 months ago

For the configurator:

For compile_and_flash_20.sh:

UI updates

dzid26 commented 6 months ago

The change looks good (except the comment above) and doesn't seem to break anything for me.

Also, do you want to have a look at https://github.com/emmebrusa/TSDZ2-Smart-EBike-1/issues/93 I just created?

dzid26 commented 6 months ago

Instead of --gui flag, can we figure out pass key input to stdin ?

https://stackoverflow.com/questions/18903549/writing-to-inputstream-of-a-java-process

Or at least provide a continue button or something.

emmebrusa commented 6 months ago

@ec-bikes The pull request is for "simple-gui-updates", I saw you made other changes with "gui-updates". What have you changed?

emmebrusa commented 6 months ago

With Linux (Ubuntu 22.04.3) it doesn't work.

See these errors:

compile_and_flash_20.sh: 8: [: --gui unexpected operator compile_and_flash_20.sh: 13: function: not found

The original configurator works.

emmebrusa commented 6 months ago

I see you're not following, you'll have your own commitments, I understand. In addition to the previous questions, I saw that there is another problem, I have a laptop with 1360x768 resolution, the compile output goes off the screen, it is not possible to read the last lines. I have to reduce it to 3 lines, it's not the best for checking if there is any problem during compilation. Let me start by saying that I know little about Java, nothing about Linux, and even less about MacOS. Searching online, I saw that a possible solution to the problem you highlighted is to use xterm, it is present in Linux distributions, or in any case installable. I tried it and I think it works. Just like in Windows. JavaConfigurator+XTerm Do you think it can also work with MacOS? I have to release a new version soon, and I have to decide what to do, I will use xterm. Let me know if it works. Thank you.