search

emmeowzing / gitlabci-lint-pre-commit-hook

A pre-commit hook that lints Gitlab CI configurations
https://pypi.org/project/pre-commit-gitlabci-lint/
MIT License
16 stars 3 forks source link

improve GITLAB_TOKEN env var #13

Closed benedikt-bartscher closed 1 year ago

benedikt-bartscher commented 1 year ago

sometimes its a good security practise to use different tokens for different things. It would be awesome if gitlabci-lint-pre-commit-hook would first try to read the token from GITLABCI_LINT_TOKEN and then fallback to GITLAB_TOKEN

emmeowzing commented 1 year ago

Absolutely this logic could be added.

emmeowzing commented 1 year ago

@benedikt-bartscher should be fixed by #14 in v1.1.6. Will work on your other request next

emmeowzing commented 1 year ago

I made improvements to this feature since I had a little time this 3 day weekend in #15