emmercm / igir

🕹 A video game ROM collection manager to help filter, sort, patch, archive, and report on collections on any OS.
https://igir.io/
GNU General Public License v3.0
308 stars 16 forks source link

Refactor: use FileProps and ArchiveEntryProps for instantiation #1003

Closed emmercm closed 3 months ago

emmercm commented 3 months ago

RE: #937

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.11%. Comparing base (e992d98) to head (a85e5bc).

Files Patch % Lines
src/modules/candidatePatchGenerator.ts 80.00% 0 Missing and 1 partial :warning:
src/types/files/file.ts 94.11% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1003 +/- ## ========================================== - Coverage 93.36% 93.11% -0.26% ========================================== Files 90 90 Lines 5699 5705 +6 Branches 1334 1329 -5 ========================================== - Hits 5321 5312 -9 - Misses 360 374 +14 - Partials 18 19 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

:test_tube: Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/file-archiveentry-props" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

github-actions[bot] commented 2 months ago

:lock: Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.