emmercm / igir

🕹 A video game ROM collection manager to help filter, sort, patch, archive, and report on collections on any OS.
https://igir.io/
GNU General Public License v3.0
308 stars 16 forks source link

Feature: support MAME software list DATs #1031

Closed emmercm closed 2 months ago

github-actions[bot] commented 3 months ago

:test_tube: Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/mame-software-lists" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 84.44444% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 93.09%. Comparing base (aef5adb) to head (015757c).

Files Patch % Lines
src/modules/datScanner.ts 61.53% 5 Missing :warning:
src/types/dats/softwarelist/softwareListDat.ts 83.33% 3 Missing :warning:
src/types/dats/softwarelist/software.ts 87.50% 2 Missing :warning:
src/types/dats/softwarelist/softwareListsDat.ts 88.88% 2 Missing :warning:
src/types/dats/softwarelist/dataArea.ts 90.90% 1 Missing :warning:
src/types/dats/softwarelist/part.ts 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1031 +/- ## ========================================== - Coverage 93.14% 93.09% -0.06% ========================================== Files 92 97 +5 Lines 6129 6211 +82 Branches 1375 1387 +12 ========================================== + Hits 5709 5782 +73 - Misses 419 428 +9 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

:lock: Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.