emmercm / igir

🕹 A video game ROM collection manager to help filter, sort, patch, archive, and report on collections on any OS.
https://igir.io/
GNU General Public License v3.0
308 stars 16 forks source link

Feature: Added RomM Export #1045

Closed maxexcloo closed 3 months ago

maxexcloo commented 3 months ago

All good to go! Based off: https://github.com/rommapp/romm/wiki/Supported-Platforms

Fixes: https://github.com/emmercm/igir/issues/1030

github-actions[bot] commented 3 months ago

:test_tube: Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:maxexcloo/igir#patch-2" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

emmercm commented 3 months ago

@maxexcloo I made some documentation changes, rather than drawing this out with more back and forth: https://github.com/emmercm/igir/pull/1045/files/cc038e0e192ef6ce0ae637407ca1f5dc4fa304cf..6fc2882d9a3568cda2650811b1c7edab82bf3592

emmercm commented 3 months ago

@maxexcloo I also needed to make some fixes, it looks like there may have been a bad merge resolution at some point: https://github.com/emmercm/igir/pull/1045/files/6fc2882d9a3568cda2650811b1c7edab82bf3592..8dfc7c8da11c0c52ff6410da39e28790fe396607

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.38%. Comparing base (dbf5566) to head (561ea64).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1045 +/- ## ======================================= Coverage 93.37% 93.38% ======================================= Files 92 92 Lines 6024 6029 +5 Branches 1436 1437 +1 ======================================= + Hits 5625 5630 +5 Misses 378 378 Partials 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

:lock: Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.