search

emmercm / igir

🕹 A zero-setup ROM collection manager that sorts, filters, extracts or archives, patches, and reports on collections of any size on any OS.
https://igir.io/
GNU General Public License v3.0
363 stars 18 forks source link

Refactor: ES-DE Name Wrong #1061

Closed maxexcloo closed 1 month ago

maxexcloo commented 6 months ago

Apologies for this one, I realize you pointed this out before. It turns out that ES-DE is not EmulationStation, I think it would make sense to rename EmulationStation to ES-DE in the code to make this accurate.

github-actions[bot] commented 6 months ago

:test_tube: Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:maxexcloo/igir#patch-1" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

emmercm commented 5 months ago

@maxexcloo do the two have different folder structures? Admittedly, I've never used any version of EmulationStation. I couldn't find reliable information about how the two might diverge.

maxexcloo commented 5 months ago

EmulationStation hasn’t been updated since 2015 so I’d say ES-DE would be a more accurate name - I think folder structures may differ very slightly (will check when I’m back at my desk).

github-actions[bot] commented 3 days ago

:lock: Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.