search

emmercm / igir

🕹 A video game ROM collection manager to help filter, sort, patch, archive, and report on collections on any OS.
https://igir.io/
GNU General Public License v3.0
306 stars 15 forks source link

Fix: make sure the cache file is writable #1070

Closed emmercm closed 3 months ago

emmercm commented 3 months ago

RE: #1060

github-actions[bot] commented 3 months ago

:test_tube: Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/test-cache-is-writable" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 93.37%. Comparing base (3b6579b) to head (0f20d82).

Files Patch % Lines
src/constants.ts 90.00% 1 Missing :warning:
src/polyfill/fsPoly.ts 87.50% 1 Missing :warning:
src/types/cache.ts 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1070 +/- ## ========================================== + Coverage 93.11% 93.37% +0.26% ========================================== Files 92 92 Lines 6009 6024 +15 Branches 1436 1436 ========================================== + Hits 5595 5625 +30 + Misses 392 378 -14 + Partials 22 21 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

:lock: Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.