emmercm / igir

🕹 A video game ROM collection manager to help filter, sort, patch, archive, and report on collections on any OS.
https://igir.io/
GNU General Public License v3.0
305 stars 15 forks source link

Fix: don't test default cache paths when one provided #1145

Closed emmercm closed 1 month ago

emmercm commented 1 month ago

Fixes: #1135

github-actions[bot] commented 1 month ago

:test_tube: Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/1135-fix" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 71.87500% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 93.19%. Comparing base (4e9033a) to head (9ca83f5).

Files Patch % Lines
src/igir.ts 63.63% 8 Missing :warning:
src/polyfill/fsPoly.ts 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1145 +/- ## ========================================== - Coverage 93.26% 93.19% -0.07% ========================================== Files 102 102 Lines 6351 6364 +13 Branches 1513 1409 -104 ========================================== + Hits 5923 5931 +8 - Misses 406 432 +26 + Partials 22 1 -21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 17 hours ago

:lock: Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.