search

emmercm / igir

🕹 A video game ROM collection manager to help filter, sort, patch, archive, and report on collections on any OS.
https://igir.io/
GNU General Public License v3.0
305 stars 15 forks source link

Refactor: split constants into two classes #1189

Closed emmercm closed 2 days ago

emmercm commented 3 days ago

RE: https://github.com/emmercm/igir/pull/1041

github-actions[bot] commented 3 days ago

:test_tube: Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/split-constants" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.06%. Comparing base (f34f9d4) to head (3e90889).

Files Patch % Lines
src/igir.ts 25.00% 3 Missing :warning:
src/constants/package.ts 93.33% 1 Missing :warning:
src/modules/updateChecker.ts 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1189 +/- ## ========================================== - Coverage 93.06% 93.06% -0.01% ========================================== Files 103 104 +1 Lines 6433 6431 -2 Branches 1523 1418 -105 ========================================== - Hits 5987 5985 -2 - Misses 423 445 +22 + Partials 23 1 -22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.