Open alienth opened 1 month ago
There is something more nuanced to this - that particular ROM that I usually see crashes on happens to be present in two separate DATs in the main No-Intro pack, both with the same checksum. I get a reliable crash when I have igir
load both of those DATs, but no crash when I only load 1 of the DATs.
Furthermore, when I attempt to narrow down to only that game, and scan no other games, the crash stops reproing. That could either be due to some actual difference in the logic, or maybe just a race condition not being hit due to less processing.
The two DATs in question are Atari - 8-bit Family (Parent-Clone) (20241010-110350).dat
and Atari - Atari 5200 (Parent-Clone) (20240806-183018).dat
.
I'll try to dig more later to narrow down what conditions result in this outcome.
Paste the command
npm exec igir@latest move test clean -vvv --input-checksum-quick --dir-dat-name --dat ./dats --input 1g1r --output 1g1r
Describe the bug
When running
move clean test
runs, igir randomly crashes withENOENT
on files which it has moved to a new directory name.In the case shown in the attached debug logs, the ROM was moved from the
Atari - 5200
directory to theAtari - 8-bit Family
directory by igir due to a name change in the DAT. In the same execution run, it subsequently attempted tostat
the file in its old location, and crashed.This seems similar to the fixed bug #367.
Expected behavior
igir
should not attempt to access files in their old location after moving them.Debug logs
Subsequent crash (occurred about 4 seconds later):
DAT(s) used
No-Intro
igir version
3.0.1
Node.js version
v20.18.0
Operating system
Debian
Additional context
No response