emmercm / igir

🕹 A zero-setup ROM collection manager that sorts, filters, extracts or archives, patches, and reports on collections of any size on any OS.
https://igir.io/
GNU General Public License v3.0
364 stars 18 forks source link

using --fixdat and clean conflict #653

Closed feurry closed 1 year ago

feurry commented 1 year ago

Paste the command

npx igir@latest copy zip clean -d *.dat -i nesSource/ -o nesOut/ --fixdat --no-bios --only-retail --single --prefer-language EN --prefer-region EUR,USA,WORLD -vvv

Describe the bug

The fixdat gets deleted and it's a confusing default. The fixdat is created and then the 'clean' happens and it gets deleted from the output directory.

I know this can be solved with something like this: --clean-exclude nesOut/*.dat (which is itself tricky if the output dir is being created with {flags}

Expected behavior

fixdat is not deleted by default. Maybe the fixdat can be generated after the 'clean' is run?

Debug logs

[19:32:52.192] INFO: CandidateWriter: Nintendo - Nintendo Entertainment System (Headered): done writing 790 candidates
[19:32:52.193] INFO: FixdatCreator: Nintendo - Nintendo Entertainment System (Headered): generating a fixdat
[19:32:52.404] INFO: FixdatCreator: Nintendo - Nintendo Entertainment System (Headered): done generating a fixdat [19:32:52.404] INFO: StatusGenerator: Nintendo - Nintendo Entertainment System (Headered): generating ROM statuses
[19:32:52.419] INFO: StatusGenerator: Nintendo - Nintendo Entertainment System (Headered): done generating ROM statuses ✓ Nintendo - Nintendo Entertainm | 790/3,098 retail releases written [19:32:52.419] INFO: done processing 1 DAT [19:32:52.420] INFO: DirectoryCleaner: cleaning files in output [19:32:52.477] DEBUG: DirectoryCleaner: cleaning 1 file [19:32:52.517] DEBUG: DirectoryCleaner: cleaning 0 empty directories [19:32:52.517] INFO: DirectoryCleaner: done cleaning files in output
✓ Cleaning output directory ···· | 1 file recycled

DAT(s) used

No response

igir version

v1.9.3

Node.js version

v20.6.1

Operating system

Ubuntu 22.04.3 LTS

Additional context

No response

emmercm commented 1 year ago

Confirmed this is definitely an issue, and definitely not what was intended. I'll make sure the fixdats are excluded from cleaning. Thank you for reporting this!

github-actions[bot] commented 11 months ago

:lock: Inactive issue lock

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.