Duplicate roms reported as UNUSED

emmercm / igir

🕹 A zero-setup ROM collection manager that sorts, filters, extracts or archives, patches, and reports on collections of any size on any OS.

https://igir.io/

GNU General Public License v3.0

364 stars 18 forks source link

Duplicate roms reported as UNUSED #982

Closed 9p6 closed 5 months ago

9p6 commented 7 months ago

Paste the command

igir report --dat ../dat/Sega\ -\ Mega\ Drive\ -\ Genesis\ (20240301-041423).dat --input *.zip

Describe the bug

As in title it confused me for a bit when analyzing report when first of rom which turned out to be duplicates was reported as FOUND and the other as UNUSED

Expected behavior

Duplicate roms present in DAT reported with correct status preferably marked as duplicate

Debug logs

I feel like they won't be needed here

DAT(s) used

No response

igir version

2.5.0

Node.js version

20.11

Operating system

Ubuntu

Additional context

No response

emmercm commented 7 months ago

@9p6 can you upload your report so I can analyze it? Feel free to redact any personal directory names.

9p6 commented 7 months ago

igir_2024-03-03T13;33;21.csv

This is result for a folder with two identical files Bare Knuckle.zip and Streets of Rage.zip.

emmercm commented 6 months ago

igir is behaving as expected here according to the rules listed in https://igir.io/output/reporting/, but I see how this could be confusing. I'll consider the suggestion of adding a new report status of DUPLICATE.

github-actions[bot] commented 4 months ago

:lock: Inactive issue lock

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.