emmercm / igir

🕹 A video game ROM collection manager to help filter, sort, patch, archive, and report on collections on any OS.
https://igir.io/
GNU General Public License v3.0
328 stars 16 forks source link

Fix: don't orphan children when filtering out parents #989

Closed emmercm closed 4 months ago

emmercm commented 4 months ago

Fixes: #987

github-actions[bot] commented 4 months ago

:test_tube: Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/fix-orphaned-children" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.37%. Comparing base (768bfc3) to head (0a1f97f).

Files Patch % Lines
src/modules/datFilter.ts 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #989 +/- ## ========================================== - Coverage 93.38% 93.37% -0.02% ========================================== Files 89 89 Lines 5582 5588 +6 Branches 1300 1303 +3 ========================================== + Hits 5213 5218 +5 - Misses 351 352 +1 Partials 18 18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

:lock: Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.