search

emmericp / MoonGen

MoonGen is a fully scriptable high-speed packet generator built on DPDK and LuaJIT. It can saturate a 10 Gbit/s connection with 64 byte packets on a single CPU core while executing user-provided Lua scripts for each packet. Multi-core support allows for even higher rates. It also features precise and accurate timestamping and rate control.
MIT License
1.04k stars 235 forks source link

Typo in Netronome-PacketGen Script #199

Open jwbensley opened 6 years ago

jwbensley commented 6 years ago

Should this be "minPacketSize = 64" ?

https://github.com/emmericp/MoonGen/blob/master/examples/netronome-packetgen/packetgen.lua#L189

NetronomeMoongen commented 6 years ago

The maxPacketSize = 64 line should be removed, since the maxPacketSize value is set on the line just below it to the actual value. Will fix this and get it upstreamed ASAP. It should however not affect functionality.

On Sat, Nov 4, 2017 at 7:21 PM, James Bensley notifications@github.com wrote:

Should this be "maxPacketSize = 64" ?

https://github.com/emmericp/MoonGen/blob/master/examples/ netronome-packetgen/packetgen.lua#L189

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/emmericp/MoonGen/issues/199, or mute the thread https://github.com/notifications/unsubscribe-auth/AS__NRwA_uRgrPBWgB7yMwrrRih_Fiycks5szJ0jgaJpZM4QSFbC .