Random wrap with abbreviation behavior

[charroma]

Since the plugin rewrite, the wrap with abbreviation keyboard shortcut sometimes does a random action instead of the desired one.

Some exemples of weird actions:

• change document syntax to xml
• open sublime preferences
• open a plugin preferences
• insert a text snippet
• sftp plugin action (really dangerous)

After the weird behavior occured once on a file, it works fine for some time. I don't know exactly what triggers it, but most of the time, it's the first time I use the shortcut on a file. It can reoccur later though.

I managed to reproduce a version of it with a new document and use the shortcut for the first time.

• The new document is "plain text".
• I change the syntax to "php" with the palette.
• I use the shortcut

After the weird replacement, I undo (cmd+Z) and reuse the shortcut (cmd+space) and it works. In the console, with sublime.log_commands(True), it shows the correct command. It's not only related to a syntax change with the palette because it also happens with documents already on the right syntax. It's probably related to the command palette in general.

https://user-images.githubusercontent.com/65042439/102908536-99480c00-4445-11eb-8686-0474f3b8ef7f.mov https://user-images.githubusercontent.com/65042439/102910192-29875080-4448-11eb-9059-8b4486d093bb.mov

[old9]

Same issue here, I tested this on a fresh installed Sublime Text 3 and installed Emmet as the only package, set up a short key for Wrap with Abbreviation (copied from the default commented key settings), and the first time I press the short key (Ctrl+Shift+G), some random thing happens.

I can reproduce this by first invoking some other command, say sort lines, and then pressing the short key again. And even worse, after this random command, Ctrl+Shift+P stops working until I press it several times.

[sergeche]

Which version of ST you’re using? I can’t reproduce this issue, when I repeat steps you’ve described, everything works fine

[charroma]

I am using 3.3.2, Build 3211. Unregistered (if this matter)

[old9]

Mine the same, 3.3.2 build 3211, on a Windows 10 64bit 20H2 box.

[old9]

Not a python guy but I did some more test

• seems that it only happens when using a short key, while calling from the command panel (Ctrl+Shift+P) works fine
• different short keys may lead to different (still random) behavior
• when it runs normally, the input block got called twice (I added some quick 'n dirty print to the console), but only once when it triggers random action
• the console always shows the correct command (command: emmet_wrap_with_abbreviation) even it's calling some random stuff, and this seems like some memory leak or something to me, the wrap_entries is passed around with a huge(?) config object in it, maybe this is something related, just a guess

[sergeche]

Maybe you have another plugin/action that bound to your shortcut? It may happen if something updates or reloads plugin, like on autoupdate or some process that touches plugin files

[charroma]

It's not the case. I changed the shortcut to a really precise shortcut ("ctrl+q", "ctrl+w", "ctrl+e", "ctrl+r") and the result is the same.

After the bug, occurs, the command palette doesnt open the next time.

[charroma]

Can't recreate the problem with Sublime 4.