emmetio / sublime-text-plugin

The essential toolkit for web-developers
https://emmet.io
MIT License
253 stars 29 forks source link

Missing semicolon in expanded values in CSS in @media #173

Closed kubiqsk closed 1 year ago

kubiqsk commented 2 years ago

(*I'll use this | as a cursor position)

Missing semicolon in expanded values in CSS in @media

It works for code like

#test{
    db|
}

it becomes

#test{
    display: block;
}

but when you're inside @media, then

@media (max-width: 767px){
    #test{
        db|
    }
}

becomes

@media (max-width: 767px){
    #test{
        display: block
    }
}

Missing semicolon means inconsistent behavior and it becomes even worse, when you want to use more attributes like m0+p0 - then there are missing semicolons everywhere

That the really big problem, because then it's completely invalid CSS

MelkonSimonyan commented 2 years ago

I have this problem too. Missing semicolon in media queries.

paulmist commented 1 year ago

This issue still persists. Is the repo still active?

sergeche commented 1 year ago

Yes, repo is active. Will check it out

paulmist commented 1 year ago

Awesome.

Let me know if I can do/provide anything to help the debug.

paulmist commented 1 year ago

Any luck finding the cause?

sergeche commented 1 year ago

Working on it, please ping me again at the end of the week, been very busy last few months

paulmist commented 1 year ago

No problem! Appreciate the work.

paulmist commented 1 year ago

Working on it, please ping me again at the end of the week, been very busy last few months

Ping!

sergeche commented 1 year ago

Just released v.2.4.0 with fix, please check it out

paulmist commented 1 year ago

Checked and confirm it's working. Thank you.