Check response success flag before status check

emmetog / ansible-jenkins

Ansible role to install and fully configure Jenkins CI in Docker

MIT License

104 stars 89 forks source link

Check response success flag before status check #41

Closed nre-ableton closed 5 years ago

nre-ableton commented 5 years ago

If the uri module fails (on account of the host being down etc) then the jenkins_home_content dict will not yet be populated and Ansible will fail with a "'dict object' has no attribute 'status'" error. Thus, we need to check that the request was successful, regardless of the HTTP status, before examining the status.

ping @emmetog, thanks!

emmetog commented 5 years ago

Thanks @nre-ableton!

nre-ableton commented 5 years ago

@emmetog Thank you, as always! 👍