search

emmetog / ansible-jenkins

Ansible role to install and fully configure Jenkins CI in Docker
MIT License
104 stars 89 forks source link

Revive wait_for task when installing plugins #49

Closed nre-ableton closed 5 years ago

nre-ableton commented 5 years ago

This was erroneously removed (by me) in db5804c. When Jenkins installs plugins, it first downloads the JPI files and then extracts them when the service restarts. Jenkins usually reports "success" back to Ansible right away and then downloads the plugin in the background.

Therefore, we need to wait for the plugin JPI files to finish appearing on Jenkins before continuing. Otherwise, the next task (configure-files.yml) will stop the service and can lead to some plugin installations being prematurely aborted, but the Ansible deployment believing that everything worked.

ping @emmetog

emmetog commented 5 years ago

Looks good @nre-ableton, thanks for the PR! It has conflicts at the moment though, could you update?

nre-ableton commented 5 years ago

@emmetog Ok, this PR should also be good to go now.

emmetog commented 5 years ago

Thanks @nre-ableton!