search

emmetog / ansible-jenkins

Ansible role to install and fully configure Jenkins CI in Docker
MIT License
104 stars 89 forks source link

Various cleanups and improvements #52

Closed nre-ableton closed 5 years ago

nre-ableton commented 5 years ago

Ok, this is my last PR, at least for awhile! 😅 I had a hack week and decided to work on this role a bit... my ultimate goal was to get centos (yum) working with the molecule tests, but I didn't manage to get quite that far. With any luck, I'll have another PR for that soon-ish.

This PR contains a few aesthetic cleanups, but also improves the overall test coverage by testing some previously-untested features of this role.

ping @emmetog -- thanks for your reviews so far! 👍

emmetog commented 5 years ago

Thanks a mill @nre-ableton !

nre-ableton commented 5 years ago

@emmetog Thanks for the quick review!