search

emmett-framework / emmett

The web framework for inventors
BSD 3-Clause "New" or "Revised" License
1.06k stars 71 forks source link

[WIP] Unit testing #101

Closed vanadium23 closed 8 years ago

vanadium23 commented 8 years ago

Hello, gi0baro.

I see your wanted help in testing from issue #3. And start working on some unit test.

Do you have any suggestions on what focus first? Also testing found some bug in SessionCookieManager, and I'll fix it soon.

Thanks in advance for answer. (:

gi0baro commented 8 years ago

@vanadium23 That's huge man, thank you! I see that you added a MakeFile, that's nice! You've added coveralls too, and even if I'm not a big fan, we can try use it; I'm not so "confident" about its results, also because it's not so smart to understand that sometimes there's no need to test some lines. Do you think we should use it?

Regarding your question, apart for what you've added, I think the router (expose module) should be one of the first to focus on.

vanadium23 commented 8 years ago

I agree, that there is no reason to have 100% coverage, because clean code is impossible. But many good products using tests (and test coverage) for stabilizing api/contracts. (So if you change something, you'll see directly from build result).

May be I'm too concerned about number, but I'd love to see 90% coverage badge at repos (:

gi0baro commented 8 years ago

@vanadium23 ok, let's add coveralls :) let me know when I can merge this.

vanadium23 commented 8 years ago

I think I'm done for now. May be later I'll add more tests, but want to do it in separate request after try more features from weppy.

gi0baro commented 8 years ago

@vanadium23 Thank you :)