emmett-framework / emmett

The web framework for inventors
BSD 3-Clause "New" or "Revised" License
1.06k stars 71 forks source link

AuthUser registration "password mismatch" - can't create new account. #156

Closed mijdavis2 closed 8 years ago

mijdavis2 commented 8 years ago

Problem Can't register a new user using the AuthUser tool.

When attempting to register a new user, using matching passwords results in "password mismatch" message display and unable to register new users.

Replicate

  1. Use bloggy example or simplified AuthUser Model like so:
# AuthModel ---------------------------------------
from weppy.tools.auth.models import AuthUser

class User(AuthUser):
    pass

# Init------------------------------------------------
from weppy import App, DAL
from weppy.tools import Auth

app = App(__name__, template_folder="./views")

# [...]

# init database and auth
from starter_weppy.models.user import User

# init auth before passing db models due to dependencies
# on auth tables in the other models
db = DAL(app)
auth = Auth(
        app, db, usermodel=User
)
  1. Run app and navigate to http://127.0.0.1:8000/account/register
  2. Attempt to create a new user with valid matching password
  3. Unable to create use and see "password mismatch" error

Version 0.7.9

OS Windows, OSX, linux

Screenshots From running bloggy (0.7.9)

weppypasswordmismatch

mijdavis2 commented 8 years ago

This looks to be fixed on current version of master (02148e43bafdd509d26d4c4dd1bad3605871e6c3)

Looking forward to the next release :bowtie: !

mijdavis2 commented 8 years ago

@gi0baro - any chance we can get a 0.7.10 with current code? 0.7.9 user creation through AuthUser is definitely broken (at least on python 3.4 and 3.5).

Not sure how tests passed for 0.7.9 release but might be UI specific bugginess. Might be a good idea to roadmap some simple selenium testing to make sure crucial UI functionality like this works.

gi0baro commented 8 years ago

@mijdavis2 Yeah, I'm sorry about this, I should really implement some integration tests above auth system. Will release a 0.7.10 later today, thank you for your patience :) 0.8 then should be probably ready the next week.

gi0baro commented 8 years ago

@mijdavis2 this is fixed in 0.7.10 :)

mijdavis2 commented 8 years ago

👍 Thanks!

If I can find the time I'll toy around with adding some lite selenium testing.