search

emmett-framework / emmett

The web framework for inventors
Other
1.06k stars 71 forks source link

FIX: import escape #415

Closed josejachuf closed 2 years ago

josejachuf commented 2 years ago

It is fixed the import escape for python3.8

gi0baro commented 2 years ago

@josejachuf thank you for this, I'm gonna add some changes to drop 3.5 testing and make it green

josejachuf commented 2 years ago

Hi @gi0baro.
Please don't forget this

Thanks

gi0baro commented 2 years ago

@josejachuf sorry for the late merge, gonna release a new 1.x later today

josejachuf commented 2 years ago

Hi @gi0baro. How are you?

For some reason this [1] is not applied

[1] https://github.com/emmett-framework/emmett/pull/415/commits/edfcae28353e1ab06e2e07a62ac988d39d3f4723

gi0baro commented 2 years ago

@josejachuf it was stashed in a single commit: https://github.com/emmett-framework/emmett/commit/9f1118c18cd8fd643433f3fe3519f92502f96aa9

I still have to issue a new release, gonna do it in the weekend