search

emmett-framework / granian

A Rust HTTP server for Python applications
BSD 3-Clause "New" or "Revised" License
2.86k stars 83 forks source link

Python code formatting and linting #123

Closed Aeron closed 1 year ago

Aeron commented 1 year ago

Considering the more people contributing to the project, especially having #116, will it be appropriate to establish the formatting and linting rules for Python code? The obvious benefit is that no contributor will doubt what development tools and styles to apply.

I will gladly provide a configuration for tools like black, isort, and ruff, for a start at least.

While doing #122, I deactivated my black and ruff plugins because any file save immediately changes too many things I didn’t touch. And those two are the industry standard by now.

gi0baro commented 1 year ago

@Aeron it definitely makes sense. If you don't mind, I gonna open a PR myself later today so I'll cover also the Rust part. I gonna ask a comment from you on that.

gi0baro commented 1 year ago

@Aeron I'd appreciate your feedbacks on #124