Changed dependency structure of typer.

emmett-framework / granian

A Rust HTTP server for Python applications

BSD 3-Clause "New" or "Revised" License

2.67k stars 79 forks source link

Changed dependency structure of typer. #261

Closed WAKayser closed 5 months ago

WAKayser commented 6 months ago

In the 0.12.0 release of typer tiangolo added extra additional dependencies that are installed unless a different package: "typer-slim" is being used.

I am willing to provide a pull request to either update the dependencies to use the typer-slim package or alternatively I can also update the cli to use the underlying "click" library.

I am wondering what your stance is on this subject?

gi0baro commented 5 months ago

@WAKayser thank you for notifying this, I wasn't aware of the changes in Typer.

I'm actually more prone to release a patch version of Granian specifying a typer version < 0.12 to quickly address this, then a PR to drop typer and directly use click is more than welcome. I initially enjoyed typer just for the typing system, but nowadays it feels quite bloated. Given the scope of Granian CLI, click would be definitely enough.

bluetech commented 5 months ago

In my opinion, even argparse is good enough, and it brings 0 dependencies :wink: