search

emmo-repo / EMMO

Elementary Multiperspective Material Ontology (EMMO)
Other
65 stars 17 forks source link

Fix deploy to GitHub pages #100

Closed jesper-friis closed 4 years ago

jesper-friis commented 4 years ago

Simplified deployment to GitHub Pages.

emanueleghedini commented 4 years ago

Reasoning error: Radian and Steradian cannot be subclasses of SpecialUnits and BaseUnits at the same time, since SpecialUnits and BaseUnits are disjoint.

jesper-friis commented 4 years ago

Well spottet. I think the right fix is to declare UnitOne as a subclass of DerivedUnit instead of BaseUnit. The SI only says that "the unit one is the neutral element of any system of units – necessary and present automatically", not that it is a base unit.

I think this deserves a separate fix, since it has nothing to do with deployment of EMMO.