emmo-repo / EMMO

Elementary Multiperspective Material Ontology (EMMO)
Other
62 stars 16 forks source link

1.0.0 alpha2 removal of redundancies and parsing errors and hierarchical issues #158

Closed Leienad closed 3 years ago

jesper-friis commented 3 years ago

Thank you @Leienad for your pull request. However, it cannot be merged into 1.0,0-beta, since your PR is based on 1.0.0-alpha2, but many things has happened since then. I also see that the most important corrections (change of xsd:decimal to xsd:double) is already implemented in 1.0.0-beta.

I would need a PR against 1.0.0-beta to check the redundancies. But for me it look like that they first appear after reasoning. We accept that sub-ontologies and the reasoner adds further specialisations. If the redundancies is a problem for you, EMMO-python has built-in functionality to remove them.

I have picked your spelling corrections, but would otherwise like to close this PR. I hope that is fine with you.