search

emmo-repo / EMMO

Elementary Multiperspective Material Ontology (EMMO)
Other
62 stars 16 forks source link

Wrong ID/subclassing for Graphics in "EMMO:Chemistry" (beta4, refactoring branches) #195

Closed adhamhashibon closed 2 years ago

adhamhashibon commented 2 years ago

issue: when loading the Chemistry reference ontology, then class ChemicalComposition is under Representation which is under id: EMMO_c7.....a55f3.

version: at least the branches 1.0.0.0-beta4and refactoring are concerned

this ID seems to belong to class Graphical (see branch origin/chemistry).

moreover, the class "Representation" seems to be only in the reference ontology Chemistry.ttl.

It seems something that should be under EMMO:Symbolic. @emanueleghedini @jesper-friis @gerhardgoldbeck what do you recon?

jesper-friis commented 2 years ago

Nice spotted. Representation should be in perceptual. I will move it and create a PR.

adhamhashibon commented 2 years ago

@jesper-friis is this now resolved (i.e., part of a pull request and is fixed etc), if so can we close it?

jesper-friis commented 2 years ago

Yes, this is resolved