emmo-repo / EMMO

Elementary Multiperspective Material Ontology (EMMO)
Other
61 stars 16 forks source link

IRIs uniformation #262

Closed hothello closed 4 months ago

hothello commented 5 months ago
hothello commented 5 months ago

A working note. As a lot of IRIs have changed, merging future branches could be time-consuming. I suggest applying the same rules before committing an merging future branches with the (updated) ./scripts/fixes.sh:

for i in $(find . -name "*ttl");
do
  # Convert the IRI with the format EMMO_hex-hex-hex-hex-hex.
  sed -i -E 's/EMMO_([0-9a-f]+)-([0-9a-f]+)-([0-9a-f]+)-([0-9a-f]+)-([0-9a-f]+)/EMMO_\1_\2_\3_\4_\5/g' "$i";
  # Convert the IRI without the EMMO_ prefix.
  sed -i -E 's/:([0-9a-f]+)_([0-9a-f]+)_([0-9a-f]+)_([0-9a-f]+)_([0-9a-f]+)/:EMMO_\1_\2_\3_\4_\5/g' "$i";
  # Convert the IRI with the format <http://emmo.info/emmo#hex_hex_hex_hex_hex>.
  sed -i -E 's/<http:\/\/emmo.info\/emmo#([0-9a-f]+)_([0-9a-f]+)_([0-9a-f]+)_([0-9a-f]+)_([0-9a-f]+)>/:EMMO_\1_\2_\3_\4_\5/g' "$i";
done
jesper-friis commented 5 months ago

Good work Otello. I think that we should make a new release before merging this PR, since it changes a lot of IRIs.

It should probably also be time-wise close to the change to w3id's, such that domain ontologies can handle the IRI-changes in one go.

hothello commented 5 months ago

Good work Otello. I think that we should make a new release before merging this PR, since it changes a lot of IRIs.

It should probably also be time-wise close to the change to w3id's, such that domain ontologies can handle the IRI-changes in one go.

The fixes on the IRIs are automatic. We could ditch this branch entirely and only save the bash script, plus the corrections to the Ontology annotations (misspelled name, wrong/old affiliations, different formats), which is a trivial merge.

hothello commented 4 months ago

I approve, but I wonder whether it would be smart to make a release and apply these changes to 1.0.0-beta6 to not make trouble for people already using 1.0.0-beta5.

It's a good idea to change the IRIs directly in the next beta release. Allow me to revert to the previous IRIs but keeping the corrections to the elucidations, then we can merge what remains to the beta5.

jesper-friis commented 4 months ago

I approve, but I wonder whether it would be smart to make a release and apply these changes to 1.0.0-beta6 to not make trouble for people already using 1.0.0-beta5.

It's a good idea to change the IRIs directly in the next beta release. Allow me to revert to the previous IRIs but keeping the corrections to the elucidations, then we can merge what remains to the beta5.

I don't think you need to do any changes. It is very easy to apply your PR to beta6 when we have released beta5.

jesper-friis commented 4 months ago

Please note: this branch is merged in to 1.0.0-beta6.

The PR is only kept here for reference.

jesper-friis commented 4 months ago

Closing - already merged into 1.0.0-beta7 and 1.0.0-final-dev-branch