emmo-repo / EMMO

Elementary Multiperspective Material Ontology (EMMO)
Other
61 stars 16 forks source link

Add chemical identifiers #274

Closed eibar-flores closed 4 months ago

eibar-flores commented 4 months ago

Is it possible to add additional chemical identifiers? Some widely used are not yet supported by emmo.

jesper-friis commented 4 months ago

Would it make sense to add two new annotation properties for them in the chemistry module?

eibar-flores commented 4 months ago

Would it make sense to add two new annotation properties for them in the chemistry module?

It is a possibility, yes. However, given InChI is already defined in EMMO, wouldn't it be confusing to define InChI Key and SMILES in a different module?

jesper-friis commented 4 months ago

I was thinking about the chemistry module in EMMO, the same module in which InChI is defined.

jesper-friis commented 4 months ago

Where you thinking about something like this: #275

eibar-flores commented 4 months ago

Where you thinking about something like this: #275

Excellent, this works. Thanks for addressing it so quickly!

jesper-friis commented 4 months ago

We will review the PR in the EMMO dev. meeting on Thursday. Then it might be merged.