emmo-repo / EMMOntoPy

Library for representing and working with ontologies in Python
https://emmo-repo.github.io/EMMOntoPy
BSD 3-Clause "New" or "Revised" License
40 stars 9 forks source link

Allow controling ontology IRI when saving #700

Closed jesper-friis closed 9 months ago

jesper-friis commented 9 months ago

Description

Allow separating the IRI of the ontology from base_iri when saving using rdflib.

Unfortunately owlready2 doesn't allow to separate the IRI of the ontology from the base_iri (the namespace of the entities in the ontology). In many ontologies, e.g. EMMO, are these not the same.

Further work: Also assign the ontology IRI when loading an ontology.

An even better solution would be to ask Jean-Baptiste to add support for separate ontology iri and base_iri to Owlready2.

Type of change

Checklist

This checklist can be used as a help for the reviewer.

Comments

codecov[bot] commented 9 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (ada4ea5) 71.30% compared to head (70f6c7b) 71.27%.

Files Patch % Lines
ontopy/ontology.py 50.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #700 +/- ## ========================================== - Coverage 71.30% 71.27% -0.03% ========================================== Files 16 16 Lines 3394 3405 +11 ========================================== + Hits 2420 2427 +7 - Misses 974 978 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.