search

emmo-repo / EMMOntoPy

Library for representing and working with ontologies in Python
https://emmo-repo.github.io/EMMOntoPy
BSD 3-Clause "New" or "Revised" License
40 stars 9 forks source link

Fixed failing test_save in master #756

Closed jesper-friis closed 5 months ago

jesper-friis commented 5 months ago

Description

Simplifying paths in test_save_emmo_domain_ontology() in test_save.py to make it much easier to debug.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.11%. Comparing base (a09e0ed) to head (d15187a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #756 +/- ## ========================================== - Coverage 72.14% 72.11% -0.03% ========================================== Files 17 17 Lines 3486 3486 ========================================== - Hits 2515 2514 -1 - Misses 971 972 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jesper-friis commented 5 months ago

There is no bug in the current master. I passes without problem.

This PR is just a simplification without any behavioral changes, so it shouldn't change whether the tests fails or not. Still it made test_save.py succeed locally for me. Merging it into PR #742, also helped that PR succeeding on github.