search

emmyarty / dxsvelte

Bring the power of Svelte to your Django projects.
https://dxsvelte.com
56 stars 2 forks source link

Move from `PyMiniRacer` to `dukpy`? #1

Closed baseplate-admin closed 1 year ago

baseplate-admin commented 1 year ago

Hey i have a small suggestion. Can we move from PyMiniRacer to duktape. Because it looks like PyMiniRacer is not updated in a long time. Whereas dukpy receives regular updates

All in all thanks for this awesome library

emmyarty commented 1 year ago

It's true that it's been a while since PMR had an update, and I'm not super familiar with Dukpy / Duktape but it's still a bit patchy in fully implementing ES5/ES6+.

I'm open to moving to a more actively maintained V8 package, I just don't think Dukpy is the right fit since I'm not keen on adding legacy transpilers into the mix, especially since we're talking about the backend where we actually have some control over the runtime and environment.

PMR uses V8 (8.9) and supports ES12 in full. For the time being, I think this is the right choice. Thoughts?

baseplate-admin commented 1 year ago

I just don't think Dukpy is the right fit since I'm not keen on adding legacy transpilers into the mix

Fair enough. I wont complain.

I'm open to moving to a more actively maintained V8 package,

since we're talking about the backend where we actually have some control over the runtime and environment.

If you want to go this route may i suggest this with this?

I think this is the right choice.

Yep if we dont wanna support DukTape its better to use PyMiniRacer

emmyarty commented 1 year ago

The proposal sounds good. It won't be something I get around to in the near future since I know exactly zero Rust, but this might just be the excuse to start I've been looking for.