search

emn178 / js-sha3

A simple SHA-3 / Keccak hash function for JavaScript supports UTF-8 encoding.
MIT License
350 stars 85 forks source link

Not SHA-3 #1

Closed mpaland closed 9 years ago

mpaland commented 9 years ago

Please be aware that your algorithm is the old suggestion of NIST. The update in 4/2014 adds padding (01), so what you are testing and implementing is basically Keccak - but not SHA-3 anymore! See the new NIST test vectors, please.

emn178 commented 9 years ago

ok, it's better to rename the method first.

2015-03-18 1:33 GMT+08:00 Marco Paland notifications@github.com:

Please be aware that your algorithm is the old suggestion of NIST. The update in 4/2014 adds padding (01), so what you are testing and implementing is basically Keccak - but not SHA-3 anymore! See the new NIST test vectors, please.

— Reply to this email directly or view it on GitHub https://github.com/emn178/js-sha3/issues/1.

emn178 commented 9 years ago

I renamed to keccak and added 2014 sha3 implementation. thanks.