search

emo-bon / observatory-profile

Repository for the templates and additional metadata, that are used to semantically uplift emo-bon logsheet data into triples
0 stars 1 forks source link

Reverse definitions of size_frac_low and size_frac_up #7

Open cpavloud opened 4 months ago

cpavloud commented 4 months ago

@09012000-tosca In the logsheet_schema_extended.csv change the definitions of size_frac_low and size_frac_up. They should be reversed (as mentioned also in the ENA checklist)

cpavloud commented 4 months ago

Discussed also here

laurianvm commented 4 months ago

Hi @marc-portier, @bulricht, Can you double check the data quality control flow for any consequences of this swap?

kmexter commented 1 month ago

does not affect the QC. @cpavloud do you want any other types of checks run on these values, e.g. that > or < is not being used - or even that we just correct that to NA?

cpavloud commented 1 month ago

In the size_frac_low and size_frac_up columns there should be no > and <. If there is for example size_frac_low >20, then this should be converted to size_frac_low 20 and size_frac_up NA But I think this should be done at the data provider side of things, no?

kmexter commented 1 month ago

yes sure, I was asking if you wanted us to add a check for that in the QC (currently there is just a check on whether the values in these columns are a float or not, and as the presence of "<" will of course make it not-a-float, there will be an error report anyway)

cpavloud commented 1 month ago

Yeah, we should probably add a check for this too.