emoacht / HelloSwitcher

A Windows desktop tool to help switching cameras for Windows Hello
MIT License
38 stars 8 forks source link

Settings only works in English #6

Closed whisdol closed 3 years ago

whisdol commented 3 years ago

Hi,

I'm using a Surface Pro 4 with an external webcam ("USB2.0 FHD UVC WebCam") that is integrated into my display (Philips 499P9H). The camera works fine for Windows Hello on another laptop (Lenovo T470) without a built-in Hello camera. After installing the HelloSwitcher tool, the settings app recognizes three cameras, but does not show their names: image

I can switch between Built-in Camera/USB Camera and "Apply", but these settings are reset after opening the Settings again.

Update: If I change my default language to English (US) (from German), the device names are displayed and the settings stick.

emoacht commented 3 years ago

Thank you for reporting. This is caused by parsing the outputs of PnPUtil. I have not noticed but under some culture settings of the OS, PnPUtil will produce language-specific outputs even if the code page is set to en-US.

I tested some cultures and found that the outputs will be:

I will make some modifications to parse language-specific outputs.

emoacht commented 3 years ago

Fixed by 2d301cd5667bc3de65f3d6c3e205949a581cad17