emolter / pylanetary

data processing and modeling tools for ring, moon, and planet observations
GNU General Public License v3.0
8 stars 6 forks source link

API changes to astroquery ring node queries will break rings modules #53

Open emolter opened 11 months ago

emolter commented 11 months ago

Problem

RingNode class was changed to RMSNode in astroquery as of Dec 15 2023. Therefore, any version of astroquery > 0.4.7.dev9008 will fail. see this page

Solution

Two-stage solution. For now, simply pin the dependencies for astroquery to be <= that dev version. Then, once astroquery does the 0.4.7 release, pin astroquery>=0.4.7

emolter commented 8 months ago

astroquery 0.4.7 has now been released, so the second part of this issue can be worked on now. Just need to rename all the imports according to what's currently in astroquery, then change the astroquery pins in pyproject.toml, requirements.txt, and docs/requirements.txt. Marking this as a good first issue