emoncms / MyHomeEnergyPlanner

My Home Energy Planner - Open Source home energy assessment software based on emoncms framework + openbem
GNU Affero General Public License v3.0
23 stars 27 forks source link

Add ability to add measure to lighting #273

Closed ghost closed 7 years ago

ghost commented 7 years ago

We need to be able to add a measure which is replacing all remaining incandescent or halogen light fittings with low energy lights.

However also think that lighting calcs need to be reviewed in light of developments in LED lighting - current SAP likely based on CFLs. Look to review forthcoming SAP, and what was said in recent consultation.

cagabi commented 7 years ago

I am implementing this now, acouple of things:

ghost commented 7 years ago

Hi Carlos,

I've added the data for the fields to the measures g-sheet, so you should be able to transfer them. Let me know if any problems.

Could you do this so it updates existing assessments? Andrew's got one nearly finished that this is relevant to (and would be good to get done soon).

In looking at this I also noted that though Andrew had applied the measure, the total number of bulbs wasn't carried through to the report - worth checking in case this is a bug.

Ta,

Marianne

cagabi commented 7 years ago

Hi,

Everything done (retrospectively). I'm closing this issue now.

You were right that the info was missing in the report, but just in the comparison table. Is that right? If not please reopen the ticket

ghost commented 7 years ago

Hi,

Just checked. I'm afraid it's also not pulling through to tables 15,16 and 17 in the report - so it makes it look like replacing lightbulbs with low energy versions has no cost attached.

It's also not showing up properly in Appendix A - detailed measures.

It's just the units - i.e. the number of lightbulbs - that's not showing. The cost is showing up, so for some reason the number of lightbulbs is not being shown, and then not being multiplied by this, to give you the total cost figure.

cagabi commented 7 years ago

That is strange, it is working for me. See picture below.

It's just the units - i.e. the number of lightbulbs - that's not showing. The cost is showing up, so for some reason the number of lightbulbs is not being shown, and then not being multiplied by this, to give you the total cost figure.

In tables 15, 16, 17 the number of them is not showing but it does show in Appendix A. Is this the problem you mean? I can add the number in the "Name" field in the tables if you want.

If what you see in your report is different than mine, can you please share the assessment with me?

issue273

ghost commented 7 years ago

Like your scenario name ;-)

Have just tried again in a different assessment, and it seems to be working. Error came up in one of Andrew's assessments (which is shared with you) - which I think was done before you applied the previous fix and the lighting library info. So could just be a legacy issue?

On 17 July 2017 at 12:57, carlos Alonso Gabizón notifications@github.com wrote:

That is strange, it is working for me. See picture below.

It's just the units - i.e. the number of lightbulbs - that's not showing. The cost is showing up, so for some reason the number of lightbulbs is not being shown, and then not being multiplied by this, to give you the total cost figure.

In tables 15, 16, 17 the number of them is not showing but it does show in Appendix A. Is this the problem you mean? I can add the number in the "Name" field in the tables if you want.

If what you see in your report is different than mine, can you please share the assessment with me?

[image: issue273] https://user-images.githubusercontent.com/7636325/28266786-b930056a-6aee-11e7-8c8f-9a261ede89d9.png

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/emoncms/MyHomeEnergyPlanner/issues/273#issuecomment-315735513, or mute the thread https://github.com/notifications/unsubscribe-auth/APjOK8wLNaRytdkrTKPgZWKicz8dooloks5sO0xGgaJpZM4M5S6c .

-- Marianne Heaslip Associate Principal

URBED (Urbanism Environment and Design) Ltda. 5th Floor, 10 Little Lever Street, Manchester, M1 1HR t. +44 (0)161 200 5500 <%2B44%20%280%29161%20200%205509> e. marianne@urbed.coop vicky@urbed.coop w. www.urbed.coop

Please note I work Wednesday to Friday. On other days, please contact my colleague Lorenza Casini.

Urban Design Group Awards 2015 - Winner in the Best Practice Category for Trent Basin Wolfson Economics Prize 2014 - Winner: Uxcester Garden City Proposal Community Land Trust Network Awards 2012 - Awarded for excellence in community engagement 2Up 2Down / Homebaked URBED (Urbanism Environment & Design ) Ltd is a limited company with co-operative rules registered in England and Wales NO. 5741006. Please access the attached hyperlink for an important electronic communications disclaimer: http://www.urbed.coop/emaildisclaimer http://www.urbed.coop/emaildisclaimer.

Please save paper and only print this email if you have to.

cagabi commented 7 years ago

The only assessment I have from Andrew is HEA020 Tuffin and there are no Light measures there. Can you check it is shared. Likely to be a legacy problem.

ghost commented 7 years ago

done.

On 17 July 2017 at 13:22, carlos Alonso Gabizón notifications@github.com wrote:

The only assessment I have from Andrew is HEA020 Tuffin and there are no Light measures there. Can you check it is shared. Likely to be a legacy problem.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/emoncms/MyHomeEnergyPlanner/issues/273#issuecomment-315740508, or mute the thread https://github.com/notifications/unsubscribe-auth/APjOK2MRR9AxrONVXdpzP3PP21TZYJ6tks5sO1ICgaJpZM4M5S6c .

-- Marianne Heaslip Associate Principal

URBED (Urbanism Environment and Design) Ltda. 5th Floor, 10 Little Lever Street, Manchester, M1 1HR t. +44 (0)161 200 5500 <%2B44%20%280%29161%20200%205509> e. marianne@urbed.coop vicky@urbed.coop w. www.urbed.coop

Please note I work Wednesday to Friday. On other days, please contact my colleague Lorenza Casini.

Urban Design Group Awards 2015 - Winner in the Best Practice Category for Trent Basin Wolfson Economics Prize 2014 - Winner: Uxcester Garden City Proposal Community Land Trust Network Awards 2012 - Awarded for excellence in community engagement 2Up 2Down / Homebaked URBED (Urbanism Environment & Design ) Ltd is a limited company with co-operative rules registered in England and Wales NO. 5741006. Please access the attached hyperlink for an important electronic communications disclaimer: http://www.urbed.coop/emaildisclaimer http://www.urbed.coop/emaildisclaimer.

Please save paper and only print this email if you have to.

cagabi commented 7 years ago

I have fixed it in HEA003 Mille as this was the only one where the measure was applied.

I had to fix it manually exporting the assessment, changing the number and importing it back.

So, if the problem was generated when I did the legacy thing (which I am sure it was), it means that there might be more assessments with the same problem. Let me know if you come across any and I'll fix it.

I'll close this issue now, but open it again if you need to

ghost commented 7 years ago

Hi Carlos,

This appears to have turned up again in a new assessment - id 179. Just shared with you now.

M

cagabi commented 7 years ago

Hi,

I have done a quick manual fix in the assessment, number of bulls replaced showing now in the report.

What I don't know is what is causing the bug. I manually changed (with my magic powers ;) the number of LLE in the scenario and applied the measure again, and it worked as expected. So there must be something breaking it somewhere.

I cannot have a proper look now, so I leave the issue open

ghost commented 7 years ago

Thanks Carlos. As you say, needs further investigation - but this fix should do it for now.

M

On 31 July 2017 at 15:20, carlos Alonso Gabizón notifications@github.com wrote:

Hi,

I have done a quick manual fix in the assessment, number of bulls replaced showing now in the report.

What I don't know is what is causing the bug. I manually changed (with my magic powers ;) the number of LLE in the scenario and applied the measure again, and it worked as expected. So there must be something breaking it somewhere.

I cannot have a proper look now, so I leave the issue open

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/emoncms/MyHomeEnergyPlanner/issues/273#issuecomment-319081222, or mute the thread https://github.com/notifications/unsubscribe-auth/APjOK14HwoSOg-t4k37FEdmR0o9016Nlks5sTeKvgaJpZM4M5S6c .

-- Marianne Heaslip Associate Principal

URBED (Urbanism Environment and Design) Ltda. 5th Floor, 10 Little Lever Street, Manchester, M1 1HR t. +44 (0)161 200 5500 <%2B44%20%280%29161%20200%205509> e. marianne@urbed.coop vicky@urbed.coop w. www.urbed.coop

Please note I work Wednesday to Friday. On other days, please contact my colleague Lorenza Casini.

Urban Design Group Awards 2015 - Winner in the Best Practice Category for Trent Basin Wolfson Economics Prize 2014 - Winner: Uxcester Garden City Proposal Community Land Trust Network Awards 2012 - Awarded for excellence in community engagement 2Up 2Down / Homebaked URBED (Urbanism Environment & Design ) Ltd is a limited company with co-operative rules registered in England and Wales NO. 5741006. Please access the attached hyperlink for an important electronic communications disclaimer: http://www.urbed.coop/emaildisclaimer http://www.urbed.coop/emaildisclaimer.

Please save paper and only print this email if you have to.