search

emoncms / MyHomeEnergyPlanner

My Home Energy Planner - Open Source home energy assessment software based on emoncms framework + openbem
GNU Affero General Public License v3.0
23 stars 27 forks source link

'select from library' option in edit fabric item model? #342

Closed TrystanLea closed 6 years ago

TrystanLea commented 6 years ago

When building the original master scenario, If I make a mistake and need to change the wall type from say library element SWU_05 to SWU_01 I cant change this by clicking on edit. Instead I have to delete the element and recreate a new one. Is this an issue or by design?

ghost commented 6 years ago

It's by design, though perhaps partly accidental - to do with the logic of the libraries and how measures are applied I think.

It might be better, if possible, to be able to change the type without having to re-enter the dimensions in the master scenario, without it recording as a 'measure' - but that might require a bit of thinking time from Carlos, as I can see it might have knock-on effects elsewhere (when you change an element in scenarios, it gets recorded as a 'measure').

cagabi commented 6 years ago

Having a look when clicking on edit doesn't give you many useful options more than changing the name. I agre, I think it makes sense in the Master scenario to allow changing the type while in the scenarios keep the apply measure as only way to do the changes

TrystanLea commented 6 years ago

It might be better, if possible, to be able to change the type without having to re-enter the dimensions in the master scenario, without it recording as a 'measure'

Thanks @marianneURBED @cagabi. I've had a go at implementing this and I think I have it working in the way you suggest without affecting any of the measures code in the scenarios. I've implemented it in the module branch:

https://github.com/emoncms/MyHomeEnergyPlanner/commit/a56814f107349a687cf740509c8c515d09384feb

cagabi commented 6 years ago

Yeah, works as expected, thanks Trystan