search

emontnemery / domoticz_mqtt_discovery

MQTT discovery plugin for Domoticz
MIT License
40 stars 28 forks source link

correction on DIMMER brightness #14

Closed papergion closed 5 years ago

papergion commented 5 years ago

correction on BLINDS (Venetian types with buttons up/stop/down) added support for percentage type BLINDS

emontnemery commented 5 years ago

It looks pretty good! Can you please check the comments though?

emontnemery commented 5 years ago

@papergion can you just explain why you changed from Subtype = 0x49 to Subtype = 0x3E here: https://github.com/emontnemery/domoticz_mqtt_discovery/pull/14#discussion_r257457114 Was there some issue with dimmers?

Also, why change from switchTypeDomoticz = 3 to switchTypeDomoticz = 15 here: https://github.com/emontnemery/domoticz_mqtt_discovery/pull/14#discussion_r257457136