search

emontnemery / domoticz_mqtt_discovery

MQTT discovery plugin for Domoticz
MIT License
40 stars 28 forks source link

[Bug] Brightness Level is 101 #15

Closed fluffymadness closed 4 years ago

fluffymadness commented 5 years ago

Thanks for developing this awesome plugin. I have one little issue, and I wonder if its related to the domoticz mobile app or a bug in the plugin itself. Basically when trying to ramp the brightness slider of any tasmota device in one go up to 100% in the domoticz android app I get the following in the mqtt logs on my domoticz server.

onCommand 001/MQTT discovery - TVLight: Command: 'Set Level', Level: 101, Color: 2019-02-13 18:30:30.666 (MQTT discovery) MqttClient::Publish tvlight/cmnd/Dimmer (101)

The Brightness level is 101 in the transmitted command resulting in tasmota discarding the value.

edit: I'm on domoticz stable

emontnemery commented 5 years ago

Do you get same issue if you max the brightness using the Domoticz web UI?

fluffymadness commented 5 years ago

I just tested. Under the domoticz webui it works as intended. I hope I got the right part of the log, but I think a different command is issued when using the brightness slider in the webui From Mobile App 2019-02-14 08:31:15.659 (MQTT discovery) onCommand 001/MQTT discovery - TVLight: Command: 'Set Level', Level: 101, Color: 2019-02-14 08:31:15.660 (MQTT discovery) MqttClient::Publish tvlight/cmnd/Dimmer (101)

From Domoticz Web Interface 2019-02-14 08:32:10.714 (MQTT discovery) 001/MQTT discovery - TVLight: Topic: 'tvlight/tele/STATE 'Setting nValue: 1->1, sValue: '69.0'->'100.0' 2019-02-14 08:32:10.714 (MQTT discovery - TVLight) Updating device from 1:'69.0' to have values 1:'100.0'.

edit: over the mobile app, the value transmitted seems to be always 1 more than intended, when selecting 46, 47 is transmitted.

emontnemery commented 5 years ago

@fluffymadness OK, then I'd argue it's a bug in the mobile app (sending wrong brightness) and in Domoticz (accepting wrong brightness and passing it on to the dimmer).

I'd suggest to open two issues:

  1. On the app: Send correct dimlevel You can refer to these Domoticz PRs where handling of dimlevel was fixed and a decrement by 1 of dimlevel was removed: domoticz/domoticz#1906 domoticz/domoticz#1921

  2. On domoticz: Clamp or reject invalid dimlevel

Let me know if no response, then I can add clamping of dimlevel to the plugin as well.

emontnemery commented 4 years ago

@fluffymadness Do you still need help with this, or has your problem been fixed in mobile app or domoticz?

fluffymadness commented 4 years ago

Hi, thanks for asking. I moved over to homeassistant in the last few months, so I don't really know if things were fixed or not.

emontnemery commented 4 years ago

OK, I'm closing this issue then.