"Ignored device topics" is too imprecise

emontnemery / domoticz_mqtt_discovery

MQTT discovery plugin for Domoticz

MIT License

40 stars 27 forks source link

Open dogtopus opened 3 years ago

dogtopus commented 3 years ago

An empty string between commas (e.g. topic1,,topic2) blacklists all topics, causing the plugin to ignore everything it saw.
Generic stuff (e.g. t) massively blacklist topics that it likely shouldn't block (e.g. tele/*, tasmota/*, etc.)

My suggesstion would be switching to fnmatch or regexp against the full topic names instead of just doing naive prefix matching.

altserg commented 2 years ago

Pull requests are welcome :)