search

emontnemery / hatasmota

MIT License
25 stars 20 forks source link

2023.9.0 shows duplicate names on Tasmota devices #247

Open SirGoodenough opened 1 year ago

SirGoodenough commented 1 year ago

I just loaded 2023.9.0 and I'm seeing duplicate Tasmota device names. Didn't see then 2023.8.4.

Running tasmota 13.1 firmware, the latest.

Screenshot_20230907_203156 Screenshot_20230907_202926

thecode commented 1 year ago

This is due to https://github.com/home-assistant/core/pull/98636 which changed entity names to comply with HA Entity naming guidelines. Issue should be better created at Home Assistant core, but to be honest it is probably going to stay like this as this was already finalized to be the standard.

I am using Tasmota as a custom component for now with this change reverted and initially did not want to release it, I have opened the repository, if you have the knowledge how to manually install a custom component you can use it until you find a better solution. I don't promise maintaining it for the long run as this is a short-term solution for me until I figure out how to bypass this. https://github.com/thecode/ha-tasmota

shaulbarlev commented 1 year ago

very annoying indeed.

emontnemery commented 1 year ago

This is a result of Tasmota using FriendlyName1 as device name if no device name is configured.

The linked PR #249 makes the integration check if the tasmota device name is same as the tasmota friendly name 1, and if it is, marks that entity as the "main feature of the device" by setting the entity's friendly name to None.

emontnemery commented 1 year ago

The linked PR only fixes the problem for a device with a single relay where the device itself is unnamed, Home Assistant needs something like https://github.com/home-assistant/architecture/discussions/957 to fix this problem for devices with multiple relays.