emoon / fs-uae

Cross-platform Amiga emulator
http://fs-uae.net/
GNU General Public License v2.0
6 stars 1 forks source link

The segment's definition message should use hex strings #2

Open prb28 opened 6 years ago

prb28 commented 6 years ago

The segment's definition message : $AS;12683280;416#43 should use hex strings $AS;c18810;1a0#.. The line in code: https://github.com/emoon/fs-uae/blob/1e7cea24777387221bd84a133423961d1cf8ee58/src/remote_debug/remote_debug.cpp#L1292

I will make the fix, but before can you tell me if there is a reason for not sending it in hex ?

emoon commented 6 years ago

Using hex should be just fine yes

prb28 commented 6 years ago

Fixed on my fork, maybe too soon for a merge request.

emoon commented 6 years ago

It would be fine. My debugger frontend is a bit on ice currently because I'm working on some UI related things first so I can updated it when needed so please go ahead and file the MR/PR 👍