dc740
commented
2 years ago Hi, I put some extra work the last couple of days on this:
- Cleaned up the dependencies to make sure we only include the ones we need on the web compilation step. Removed any other dependency from the rest of the work.
- Squashed the huge list of commits into only one.
- Worked on a multi platform demo that can be compiled to desktop AND web: https://github.com/dc740/minifb-async-examples
This is usable now. Getting minifb on the web requires some extra work, and I can't provide a simple example to do "cargo run minifb_web", that's why I had to add the example in other repository.
I kept it as small as possible, and after some research I don't think there is any other way to implement it. There is no way to keep the simple application loop that the desktop uses, but after this PR it's possible to finally run a (mostly canon) minifb application on the web using webassembly and some auto generated javascript glue code as shown in the demo.
I was hoping this PR could be merged so other people can start making improvements on it. Let me know if you think that's possible, or which things you think are blocking this PR.
emoon
This is a possible implementation, based on @tversteeg code. For the web part to work you need to have an executor and use spawn_local. This implementation does not force any executor, in fact, it does not even care what you use.
I still need to work on an example, and test it. It compiles, and all that really matters on this is to always keep a reference to the window, so the buffer does not go out of scope (which would trigger this: https://github.com/rustwasm/wasm-bindgen/issues/2445 ) Compile using: