Changing return types of get_keys from Option<Vec<Key>> to Vec<Key>

emoon / rust_minifb

Cross platfrom window and framebuffer crate for Rust

MIT License

1k stars 95 forks source link

Changing return types of get_keys from Option<Vec<Key>> to Vec<Key> #260

Closed Zij-IT closed 2 years ago

Zij-IT commented 2 years ago

As previously discussed in #259, there is currently not a reason for the functions to be returning an Option<Vec<Key>> as opposed to Vec<Key>. This pull request should contain all changes necessary for all get_keys functions. The docs for the functions are also updated, as not updating them felt weird :D

I was able to successfully build on macOS BigSur without issues, and I believe I made all the changes for the rest of the operating systems as well.

emoon commented 2 years ago

Thanks for the PR!

It looks good, but there are some things failing with the CI tests so please fix them and I should be able to merge soon after :)

emoon commented 2 years ago

Thanks!

Zij-IT commented 2 years ago

Not a problem! Thanks for your work in making minifb as awesome as it is :)